Skip to content

Clean up ClickToDial OAS validation warnings#96

Merged
YadingFang merged 1 commit intomainfrom
oas/cleanup-validation-warnings
May 7, 2026
Merged

Clean up ClickToDial OAS validation warnings#96
YadingFang merged 1 commit intomainfrom
oas/cleanup-validation-warnings

Conversation

@YadingFang
Copy link
Copy Markdown
Contributor

@YadingFang YadingFang commented May 7, 2026

What type of PR is this?

cleanup

What this PR does / why we need it:

This PR cleans up non-blocking CAMARA Validation warnings/hints in the ClickToDial OAS before the second r1.3 release candidate.

It addresses ClickToDial-owned OAS findings where the fix is local and does not change the API wire format:

  • add an EventType enum schema for ClickToDial event types;
  • rename ClickToDial-owned local schemas to PascalCase;
  • add a conservative pattern for CallId;
  • remove unused local wrapper schemas where common artifacts are referenced directly.

This follows the feedback in #94 to consider addressing the remaining warnings, including schema naming such as sink vs Sink.

Special notes for reviewers:

This PR intentionally does not modify:

  • release-plan.yaml;
  • code/common/*;
  • CHANGELOG.md;
  • README.md;
  • .github/workflows/*.

The files under code/common/* are kept synced with Commonalities r4.2 via .sync-manifest.yaml and are not manually edited in this PR.

This PR does not execute /create-snapshot and does not start the release process.

Any remaining findings located in code/common/* should be handled centrally by Commonalities/tooling rather than locally in ClickToDial.

Changelog input

Clean up non-blocking OAS validation warnings without changing the API wire format.

@camara-validation
Copy link
Copy Markdown

camara-validation Bot commented May 7, 2026

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

Signed-off-by: Yading Fang <fangyading@chinamobile.com>
@YadingFang YadingFang force-pushed the oas/cleanup-validation-warnings branch from 3a45a71 to ffd4cab Compare May 7, 2026 07:56
@YadingFang YadingFang marked this pull request as ready for review May 7, 2026 08:12
Copy link
Copy Markdown

@Wojiaozhenghao Wojiaozhenghao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@YadingFang YadingFang merged commit 4cd13e8 into main May 7, 2026
3 checks passed
@YadingFang YadingFang mentioned this pull request May 7, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants